Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug21065 035 #2053

Open
wants to merge 2 commits into
base: maint-0.3.5
Choose a base branch
from
Open

Conversation

nmathewson
Copy link
Contributor

No description provided.

Part of a fix for 20165: we will use this information to see whether
we can call a self-test successful.
Previously we'd treat an incoming circuit as indicating orport
reachability, even if it was to an ORPort other than the one we were
trying to test.  Now we only treat it as indicating reachability
when it is on a canonical-to-peer channel: one where the address
matched our published address when the channel was made.

Fixes bug introduced in 4f5192b in 0.1.0.1-rc, back when we
added self-reachability tests. Closes 20165.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9781

  • 0 of 6 (0.0%) changed or added relevant lines in 2 files are covered.
  • 14 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+1.7%) to 60.923%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/or/circuitbuild.c 0 2 0.0%
src/core/or/channeltls.c 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_common.c 1 82.3%
src/feature/dirauth/shared_random.c 4 85.1%
src/feature/dirauth/dirvote.c 9 64.65%
Totals Coverage Status
Change from base Build 9738: 1.7%
Covered Lines: 44574
Relevant Lines: 73165

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants